Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Es labels #585

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Es labels #585

merged 4 commits into from
Mar 2, 2020

Conversation

ericsturman
Copy link
Contributor

@tnrich I have wrapped up the code changes and added an e2e test...

@ericsturman
Copy link
Contributor Author

ericsturman commented Feb 29, 2020

One thing I did notice is that the cutsite labels look a little weird below the sequence text in the Sequence Map. If the sequence text is present in the RowView we might want to have them positioned above the cutsite box (and also put the features above the sequence text). What do you think?

@tnrich
Copy link
Contributor

tnrich commented Mar 1, 2020

@ericsturman good catch on the cutsite labels, I didn't realize I had put them too far down in the stack. I'll take a look and fix that.

@tnrich
Copy link
Contributor

tnrich commented Mar 2, 2020

@ericsturman I'm going to merge this in, fix the issues you mentioned and make a few additional changes to allow this to be user configurable and persisted to localstorage. I'll let you know when I cut a release.

@tnrich tnrich merged commit 023976f into TeselaGen:es_labels Mar 2, 2020
@tnrich
Copy link
Contributor

tnrich commented Mar 2, 2020

@ericsturman whoops didn't realize you added the persisted options already

@ericsturman
Copy link
Contributor Author

@tnrich This looks great; we do great work! I did notice that in the Sequence Map there are some restriction enzymes not getting their label (ex: NruI at 619 in the demo page). It looks like it needs to be an exception from the onlyShowLabelsThatDoNotFit logic.

@tnrich
Copy link
Contributor

tnrich commented Mar 2, 2020

@ericsturman good catch! That makes sense. We don't want to filter out any cutsite labels at all there. I'll fix that

@tnrich
Copy link
Contributor

tnrich commented Mar 3, 2020

@ericsturman fixed in v10.1.53

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants