ORFs AA size should not include the terminal codon translation *

[XingGao-PKI]

When a DNA/RNA translated to AA sequence in ORFs, a terminal codon translation * is always included, this is not a valid AA, we should reduce one AA from the AA size.

E.g: this sequence
atgactgaatacaagcctactgtcaggttggctacaagagacgacgttcctagagccgtgagaactctggctgcagccttcgccgactaccccgccacgagacacaccgttgacccagatcggcatattgagagagtgactgaactgcaggagctgtttcttacaagagttggcctcgacataggcaaggtgtgggtggcggacgacggcgccgccgtggccgtctggaccactcccgaatcagttgaggctggcgccgtattcgctgagatcggcccgagaatggctgagctcagcgggagtaggctcgcggcacagcagcaaatggagggactgctggcaccacacaggcccaaagaacccgcctggttcctggcaaccgtcggtgtatctcccgatcatcaggggaaaggtctgggctctgccgtagtgctccctggcgtggaggcagctgagagagcaggagtacctgccttcttggagacctccgctccaaggaatcttcccttctatgaacggttgggcttcaccgtgacagccgacgtggaagtccccgaaggcccccgcacttggtgcatgacgaggaagcctggagcgtga
is translate to AA sequence MTEYKPTVRLATRDDVPRAVRTLAAAFADYPATRHTVDPDRHIERVTELQELFLTRVGLDIGKVWVADDGAAVAVWTTPESVEAGAVFAEIGPRMAELSGSRLAAQQQMEGLLAPHRPKEPAWFLATVGVSPDHQGKGLGSAVVLPGVEAAERAGVPAFLETSAPRNLPFYERLGFTVTADVEVPEGPRTWCMTRKPGA*
This AA string size is 200, but the actual valid AA size should be 199.

[codecov-commenter]

Codecov Report

Merging #771 (60df502) into master (b26a2a7) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   72.11%   72.53%   +0.42%     
==========================================
  Files         243      243              
  Lines        9262     9267       +5     
  Branches     3124     3124              
==========================================
+ Hits         6679     6722      +43     
+ Misses       2284     2250      -34     
+ Partials      299      295       -4     

Impacted Files	Coverage Δ
...helperComponents/PropertiesDialog/OrfProperties.js	76.19% <ø> (ø)
src/withEditorInteractions/index.js	78.81% <0.00%> (-0.02%)	⬇️
src/commands/index.js	74.27% <0.00%> (+0.04%)	⬆️
demo/src/EditorDemo/index.js	85.49% <0.00%> (+0.29%)	⬆️
src/MenuBar/viewSubmenu.js	72.72% <0.00%> (+9.09%)	⬆️
src/RowItem/Orf.js	73.07% <0.00%> (+73.07%)	⬆️
src/RowItem/Orfs.js	100.00% <0.00%> (+100.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26a2a7...60df502. Read the comment docs.

[cypress]

---

Test summary

196 • 0 • 0 • 0

---

Run details

Project	openVectorEditor
Status	Passed
Commit	5893ab1 ℹ️
Started	Sep 17, 2021 1:04 AM
Ended	Sep 17, 2021 1:14 AM
Duration	10:22 💡
OS	Linux Ubuntu - 16.04
Browser	Electron 91

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[tnrich]

@XingGao-PKI thank you for this excellent PR. Could you please set up a simple cypress test for it?

Thank you!

[XingGao-PKI]

Close PR and Reopen to trigger the Blocked Cypress tests

[tnrich]

Nice work @XingGao-PKI ! Thank you!

[tnrich]

Published a new version 16.3.35 for you @XingGao-PKI