Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

fix warning on css import order #864

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix warning on css import order #864

merged 1 commit into from
Nov 18, 2022

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Nov 18, 2022

Fix following warning during vite build

Screenshot from 2022-11-18 00-55-01

@codecov-commenter
Copy link

Codecov Report

Merging #864 (747c596) into master (2e6a311) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   74.67%   74.94%   +0.27%     
==========================================
  Files         271      289      +18     
  Lines       10672    11116     +444     
  Branches     3813     3997     +184     
==========================================
+ Hits         7969     8331     +362     
- Misses       2367     2444      +77     
- Partials      336      341       +5     
Impacted Files Coverage Δ
demo/src/VersionSwitcher.js 28.57% <0.00%> (-60.32%) ⬇️
src/SimpleCircularOrLinearView.js 71.62% <0.00%> (-24.04%) ⬇️
addons/AutoAnnotate/src/fileUtils.js 37.50% <0.00%> (-12.50%) ⬇️
demo/src/utils/renderToggle.js 84.61% <0.00%> (-8.49%) ⬇️
addons/AutoAnnotate/src/index.js 66.44% <0.00%> (-7.87%) ⬇️
src/CutsiteFilter/index.js 85.85% <0.00%> (-5.36%) ⬇️
...rc/RowItem/StackedAnnotations/PointedAnnotation.js 92.43% <0.00%> (-4.00%) ⬇️
src/CircularView/RotateCircularViewSlider.js 86.36% <0.00%> (-2.53%) ⬇️
src/selectors/filteredCutsitesSelector.js 82.35% <0.00%> (-1.97%) ⬇️
src/RowView/estimateRowHeight.js 88.73% <0.00%> (-1.13%) ⬇️
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tnrich tnrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @smeng9 !

@tnrich tnrich merged commit d64a684 into TeselaGen:master Nov 18, 2022
@tnrich
Copy link
Contributor

tnrich commented Nov 18, 2022

@smeng9 publishing this in v18.1.48 now! Lemme know if that does it for ya!

@tnrich
Copy link
Contributor

tnrich commented Nov 18, 2022

Also, could you link to where you're bundling OVE using vite? (if it's a public repo that is)!

Thanks,
Thomas

@smeng9
Copy link
Contributor Author

smeng9 commented Nov 19, 2022

I can publish a tutorial to use vite.

It provides so much speed up

@tnrich
Copy link
Contributor

tnrich commented Nov 28, 2022

@smeng9 please let me know when you publish that tutorial and include a link to it. Thanks!

@smeng9
Copy link
Contributor Author

smeng9 commented Dec 2, 2022

@tnrich
Copy link
Contributor

tnrich commented Dec 2, 2022

Thanks for posting this @smeng9 ! I'm definitely interested in trying out using vite as the default bundler for developing OVE

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants