Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Fix tickSpacing not working issue #868

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

XingGao-PKI
Copy link
Contributor

No description provided.

@cypress
Copy link

cypress bot commented Dec 15, 2022



Test summary

263 0 1 0


Run details

Project openVectorEditor
Status Passed
Commit bcfb9bd
Started Dec 15, 2022 8:49 AM
Ended Dec 15, 2022 9:19 AM
Duration 30:39 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Dec 15, 2022



Test summary

258 5 1 0


Run details

Project openVectorEditor
Status Failed
Commit f914305 ℹ️
Started Dec 15, 2022 8:53 AM
Ended Dec 15, 2022 9:24 AM
Duration 30:18 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Failures

editor.spec.js Failed
1 editor > should handle clickOverrides correctly if they are passed
proteinEditor.spec.js Failed
1 proteinEditor > feature/part add/edit should be AA indexed
dialogs.spec.js Failed
1 dialogs > part dialog should -handle changing strand direction -todo handle notes add
chromatogram.spec.js Failed
1 chromatogram > the chromatogram visibility toggle shouldn't show up unless chromatogramData is present
onSavePng.spec.js Failed
1 onSavePng > generate a png onSave if pngGenerate option is set to true

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-commenter
Copy link

Codecov Report

Merging #868 (bcfb9bd) into master (585f1bb) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
- Coverage   75.31%   75.19%   -0.12%     
==========================================
  Files         290      290              
  Lines       11159    11176      +17     
  Branches     4022     4030       +8     
==========================================
  Hits         8404     8404              
- Misses       2419     2435      +16     
- Partials      336      337       +1     
Impacted Files Coverage Δ
src/LinearView/index.js 84.17% <100.00%> (+0.11%) ⬆️
src/MenuBar/index.js 65.38% <0.00%> (-26.93%) ⬇️
demo/src/EditorDemo/index.js 83.49% <0.00%> (-2.54%) ⬇️
src/RowView/index.js 90.26% <0.00%> (-0.77%) ⬇️
src/AlignmentView/index.js 73.33% <0.00%> (-0.05%) ⬇️
src/RowItem/index.js 77.65% <0.00%> (ø)
src/MenuBar/viewSubmenu.js 100.00% <0.00%> (ø)
src/redux/annotationVisibility.js 80.00% <0.00%> (ø)
src/utils/useChromatogramPrefs.js 100.00% <0.00%> (ø)
src/AlignmentView/updateTrackHelper.js 40.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tnrich tnrich merged commit 1ca4376 into TeselaGen:master Dec 15, 2022
@tnrich
Copy link
Contributor

tnrich commented Dec 15, 2022

@XingGao-PKI thanks for this! Good catch!

@tnrich
Copy link
Contributor

tnrich commented Dec 15, 2022

Will land in v18.1.62 which is publishing now

@XingGao-PKI XingGao-PKI deleted the fixTickSpacing branch August 16, 2023 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants