Add on-call recommendations by Sgtpluck · Pull Request #298 · 18F/development-guide

Sgtpluck · 2022-03-02T19:57:51Z

No description provided.

github-actions · 2022-03-02T20:10:38Z

Pa11y testing results

> development-guide@1.0.0 pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 41 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

✔ 41/41 URLs passed

_pages/on-call.md

alexsobledotgov · 2022-03-02T20:34:26Z

Preview link in case it's helpful for reviewers!

_pages/on-call.md

github-actions · 2022-03-02T20:40:24Z

Pa11y testing results

> development-guide@1.0.0 pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 41 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215
    this.emit('error', new Error('Page crashed!'));
                       ^

Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (node:events:520:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (node:events:520:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (node:events:520:28)
Emitted 'error' event on Page instance at:
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:10)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    [... lines matching original stack trace ...]
    at Receiver.emit (node:events:520:28)

alexsobledotgov · 2022-03-02T20:44:50Z

@Sgtpluck Looks great to me, thank you so much for taking on this work and contributing this guide! 🙌

github-actions · 2022-03-03T21:55:10Z

Pa11y testing results

> development-guide@1.0.0 pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 41 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

✔ 41/41 URLs passed

neilmb

LGTM, nothing but nitpicking from me.

_pages/on-call.md

rahearn

Great work. I agree with @neilmb's nitpicks and I'm also wondering about the 18F focus of the intro.

I think this is a solid set of recommendations for any project so we can maybe remove the 18F references other than maybe just a quick special-case aside in the staffing section, since that is pretty different for 18F projects vs the rest of TTS. That said - I approve this as-is if we want to table that generalization to later.

github-actions · 2022-03-04T17:00:51Z

Pa11y testing results

> development-guide@1.0.0 pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 41 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

✔ 41/41 URLs passed

github-actions · 2022-03-04T17:01:44Z

Pa11y testing results

> development-guide@1.0.0 pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 41 URLs:
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/books-we-have-read/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215
    this.emit('error', new Error('Page crashed!'));
                       ^

Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (node:events:520:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (node:events:520:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (node:events:520:28)
Emitted 'error' event on Page instance at:
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:10)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    [... lines matching original stack trace ...]
    at Receiver.emit (node:events:520:28)

Add on-call recommendations

1be5cba

lauraGgit reviewed Mar 2, 2022

View reviewed changes

_pages/on-call.md Outdated Show resolved Hide resolved

perldude reviewed Mar 2, 2022

View reviewed changes

_pages/on-call.md Outdated Show resolved Hide resolved

Fix typo

55e90d6

Sgtpluck force-pushed the dmm/on-call-recs branch from 975627c to 55e90d6 Compare March 3, 2022 21:53

neilmb approved these changes Mar 4, 2022

View reviewed changes

_pages/on-call.md Outdated Show resolved Hide resolved

_pages/on-call.md Outdated Show resolved Hide resolved

_pages/on-call.md Outdated Show resolved Hide resolved

rahearn approved these changes Mar 4, 2022

View reviewed changes

PR feedback

987399d

Sgtpluck force-pushed the dmm/on-call-recs branch from afc1894 to 987399d Compare March 4, 2022 17:00

hartsick approved these changes Mar 4, 2022

View reviewed changes

geekygirlsarah approved these changes Mar 4, 2022

View reviewed changes

svenaas approved these changes Mar 4, 2022

View reviewed changes

Sgtpluck merged commit f103eed into main Mar 7, 2022

Sgtpluck deleted the dmm/on-call-recs branch March 7, 2022 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add on-call recommendations#298

Add on-call recommendations#298
Sgtpluck merged 3 commits intomainfrom
dmm/on-call-recs

Sgtpluck commented Mar 2, 2022

Uh oh!

github-actions bot commented Mar 2, 2022

Uh oh!

Uh oh!

alexsobledotgov commented Mar 2, 2022

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2022

Uh oh!

alexsobledotgov commented Mar 2, 2022

Uh oh!

github-actions bot commented Mar 3, 2022

Uh oh!

neilmb left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahearn left a comment

Uh oh!

github-actions bot commented Mar 4, 2022

Uh oh!

github-actions bot commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

Sgtpluck commented Mar 2, 2022

Uh oh!

github-actions bot commented Mar 2, 2022

Uh oh!

Uh oh!

alexsobledotgov commented Mar 2, 2022

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2022

Uh oh!

alexsobledotgov commented Mar 2, 2022

Uh oh!

github-actions bot commented Mar 3, 2022

Uh oh!

neilmb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahearn left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 4, 2022

Uh oh!

github-actions bot commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants