Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Change secondary org to 18F in identifier (footer region). #319

Closed
wants to merge 1 commit into from

Conversation

cannandev
Copy link
Contributor

@cannandev cannandev commented Aug 25, 2022

What's wrong?

👋🏾 Hi. I'm working on the 18F Guides and Methods. We noticed the Engineering Guide identifier says "This project is maintained by Technology Transformation Services" but the link points to 18F. The other guides say "This project is maintained by 18F".

image

What am I proposing?

Change the secondary org to 18F in the yml file. The primary org is still TTS.

image

Federalist preview:

https://federalist-0fc100fe-c4d0-4b8f-bd4f-7392edd7c16d.app.cloud.gov/preview/18f/development-guide/cannandev-maintained-by-18F-identifier-org/

@cannandev cannandev self-assigned this Aug 25, 2022
@github-actions
Copy link

Pa11y testing results
> [email protected] pa11y-ci:sitemap
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 44 URLs:
/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215
    this.emit('error', new Error('Page crashed!'));
                       ^

Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (node:events:513:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (node:events:513:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (node:events:513:28)
Emitted 'error' event on Page instance at:
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:10)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    [... lines matching original stack trace ...]
    at Receiver.emit (node:events:513:28)

@cannandev cannandev changed the title Change secondary org to 18F. Change secondary org to 18F in identifier (footer region). Aug 25, 2022
@@ -13,8 +13,8 @@ org_primary_url: https://www.gsa.gov/tts/
org_primary_email: [email protected]
org_primary_about: https://www.gsa.gov/tts/
org_primary_bio: "As part of GSA’s Technology Transformation Services (TTS), we apply modern methodologies and technologies to improve the public’s experience with government. We help agencies make their services more accessible, efficient, and effective with modern applications, platforms, processes, personnel, and software solutions."
org_secondary: Technology Transformation Services
org_secondary_acronym: TTS
org_secondary: 18F
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org_secondary currently contains information from each of TTS, 18F, and TTS Solutions (see org_secondary_bio on line 22). What does org_secondary mean here? And should we change all of it to reflect 18F for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (and this is my personal opinion as a guide user) primary should be a reference to TTS and secondary should refer to 18F consistently. Looks like org_primary_bio and org_secondary_bio aren't being used anyway in the templates and can be removed. But as the product owner, it's your call :)

@svenaas
Copy link

svenaas commented Aug 29, 2022

@cannandev, I'm not sure about this change, and perhaps we should discuss the matter further before proceeding.

The Engineering Practices Guide used to be 18F specific but was broadened to cover TTS engineering. Stewarding this repository is the responsibility of the TTS Engineering Practices Guild co-leads — currently @kbighorse and me. The Guild used to be an 18F specific organization but was similarly broadened, and the co-leads aren't necessarily 18F engineers (I'm not). I think it's inaccurate to specifically state that this is maintained by 18F.

@cannandev
Copy link
Contributor Author

@cannandev, I'm not sure about this change, and perhaps we should discuss the matter further before proceeding.

The Engineering Practices Guide used to be 18F specific but was broadened to cover TTS engineering. Stewarding this repository is the responsibility of the TTS Engineering Practices Guild co-leads — currently @kbighorse and me. The Guild used to be an 18F specific organization but was similarly broadened, and the co-leads aren't necessarily 18F engineers (I'm not). I think it's inaccurate to specifically state that this is maintained by 18F.

@svenaas Thank you so much for bringing this up. Saying "This project is maintained by 18F" would not be accurate. This is something the Guides and Methods will keep in mind going forward. I'm going to close out this PR. Looking forward to having more discussions with you both regarding stewardship! 💯

@cannandev cannandev closed this Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants