Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalPy support #694

Merged
merged 18 commits into from
Oct 10, 2023
Merged

Add GraalPy support #694

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ad7b7ba
Add support for graalpy
timfel Jun 27, 2023
f40a022
add graalpy test workflow
timfel Jun 28, 2023
6db14b2
format, lint and build
timfel Jun 30, 2023
928058c
symlink graalpy binaries names
timfel Jun 30, 2023
b695933
fix macos names for graalpy
timfel Aug 21, 2023
b271e81
Don't attempt to update pip for graalpy
msimacek Aug 25, 2023
fb29473
Remove test schedule
msimacek Aug 29, 2023
08f6b91
Extract common getBinaryDirectory function for PyPy and GraalPy
msimacek Aug 29, 2023
3d8a1eb
Clean up and format
msimacek Aug 29, 2023
62fe528
Pass GitHub token to GraalPy queries
msimacek Aug 29, 2023
feb1894
Utilize pagination when querying GraalPy GitHub releases
msimacek Aug 29, 2023
7673153
Build
msimacek Aug 29, 2023
546edbc
Fix lint errors
msimacek Aug 30, 2023
8c79e75
Deal with possible multiple artifacts for a single releases
msimacek Aug 30, 2023
cc7e956
Skip few GraalPy tests on windows - we don't have a windows release yet
msimacek Aug 30, 2023
7f48d18
Fix GraalPy test on Mac OS
msimacek Aug 30, 2023
5b60f8c
Build
msimacek Aug 30, 2023
6713183
Skip one more GraalPy test on windows
msimacek Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip one more GraalPy test on windows
  • Loading branch information
@msimacek
msimacek committed Aug 31, 2023
commit 67131832f0581393db2afabe3dc41269e88d4500
7 changes: 5 additions & 2 deletions __tests__/find-graalpy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import * as path from 'path';
import * as semver from 'semver';

import * as finder from '../src/find-graalpy';
import {IGraalPyManifestRelease} from '../src/utils';
import {IGraalPyManifestRelease, IS_WINDOWS} from '../src/utils';

import manifestData from './data/graalpy.json';

Expand All @@ -19,6 +19,9 @@ const architecture = 'x64';
const toolDir = path.join(__dirname, 'runner', 'tools');
const tempDir = path.join(__dirname, 'runner', 'temp');

/* GraalPy doesn't have a windows release yet */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraalPy is downloadable for Windows; is this comment still correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct, the last release for GraalPy is 23.0.1 and doesn't have Windows binaries. The upcoming 23.1 will have binaries, but they are very limited.

const describeSkipOnWindows = IS_WINDOWS ? describe.skip : describe;

describe('parseGraalPyVersion', () => {
it.each([
['graalpy-23', '23'],
Expand Down Expand Up @@ -105,7 +108,7 @@ describe('findGraalPyToolCache', () => {
});
});

describe('findGraalPyVersion', () => {
describeSkipOnWindows('findGraalPyVersion', () => {
let getBooleanInputSpy: jest.SpyInstance;
let warningSpy: jest.SpyInstance;
let debugSpy: jest.SpyInstance;
Expand Down