multiple code improvements: squid:S1192, squid:S1118, squid:S1066, squid:S1854, squid:S2864#34
Merged
adangel merged 1 commit intoadangel:masterfrom May 20, 2016
DevFactory:release/multiple-code-improvements-fix-1
Merged
multiple code improvements: squid:S1192, squid:S1118, squid:S1066, squid:S1854, squid:S2864#34adangel merged 1 commit intoadangel:masterfrom DevFactory:release/multiple-code-improvements-fix-1
adangel merged 1 commit intoadangel:masterfrom
DevFactory:release/multiple-code-improvements-fix-1
Conversation
…uid:S1854, squid:S2864
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:S1192 - String literals should not be duplicated.
squid:S1118 - Utility classes should not have public constructors.
squid:S1066 - Collapsible "if" statements should be merged.
squ id:S1854 - Dead stores should be removed.
squid:S2864 - "entrySet()" should be iterated when both the key and value are needed.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1192
https://dev.eclipse.org/sonar/rules/show/squid:S1118
https://dev.eclipse.org/sonar/rules/show/squid:S1066
https://dev.eclipse.org/sonar/rules/show/squid:S1854
https://dev.eclipse.org/sonar/rules/show/squid:S2864
Please let me know if you have any questions.
George Kankava