#13 動的タイトル #18

su8ru · 2020-09-13T09:16:17Z

close #13

index.html に置く静的なタイトルは loading ... とかも考えたんですが、どっちがいいんだろう

ibuki2003

useTitleでも用意して統一をしたい h1を置くなら返り値をstringにしてそれを読むとかもできるし(これは2箇所に定数を置くことへの対策)…

src/libs/title.ts

su8ru added 5 commits September 10, 2020 17:42

feat: title context

26fb9a6

lint: turn off react-hooks/exhaustive-deps

c6887b9

feat: document title

38ab0b3

fix: static (default) title

f101b04

refactor: rename title.ts -> titleContext.ts

d34dedd

su8ru added the enhancement New feature or request label Sep 13, 2020

su8ru requested review from Takeno-hito and ibuki2003 September 13, 2020 09:16

su8ru self-assigned this Sep 13, 2020

Takeno-hito previously approved these changes Sep 13, 2020

View reviewed changes

ibuki2003 suggested changes Sep 13, 2020

View reviewed changes

su8ru added 2 commits September 14, 2020 15:29

feat: use custom hook

0c104a8

fix: add new title in use effect deps

aaa9072

su8ru dismissed Takeno-hito’s stale review via 0c104a8 September 14, 2020 11:08

su8ru requested a review from ibuki2003 September 14, 2020 11:09

ibuki2003 suggested changes Sep 14, 2020

View reviewed changes

src/libs/title.ts Outdated Show resolved Hide resolved

su8ru requested review from ibuki2003 and Takeno-hito September 14, 2020 11:24

ibuki2003 approved these changes Sep 14, 2020

View reviewed changes

Takeno-hito approved these changes Sep 14, 2020

View reviewed changes

su8ru merged commit 7e05181 into develop Sep 14, 2020

su8ru deleted the feature/#13_dynamic_title branch September 15, 2020 00:24

Provide feedback