DEV: Added multiple countries view

[Shivathanu]

Description:

Added option to view multiple countries data in table / chart format.

Instructions:

Multiple countries are input to the cli as below format in order for the data retreival of multiple countries.

Run command:

corona --s country india,ecuador,portugal

Fixes #54

[ghost]

Changes requested

Since this PR meant to work on multiple countries, some things are not looking right:

• the API url is set to a single country;
• var name refers to a single country.

Could you please review these items ?

[ghost]

Isn't this getting just 1 country ? Example:

https://corona.lmao.ninja/v2/countries/Brazil gets data from Brazil only. Shouldn't it stop on "/countries" ?

Click the link to see it: https://corona.lmao.ninja/v2/countries/

[Shivathanu]

The issue #54 description states that we need to provide multiple countries to the command line input, for example in this case to test (since not yet deployed) the command :

node index.js --s country algeria,france,italy

Hence we are using the api which allows to get the specified countries input params :

https://corona.lmao.ninja/v2/countries/:countryList

{where :countryList -> (algeria,france,italy) in this case}

Thanks

[ghost]

Since it's about multiple countries, maybe the name should have "countries"

[Shivathanu]

Yes, I agree having countries as variable name seems more meaningful. I have changed that in the latest commit.

[ghost]

As in line 10, since https://corona.lmao.ninja/v2/countries/${countryName} refers to a single country, has this .map() worked ?

[Shivathanu]

I have added a condition here, since previously it worked only for multiple countries input. Now it will work for single country, but the functionality here is for multiple country as mentioned above (#104 (comment))

[ghost]

This was the output when I've tried to run this:

× UNHANDLED ERROR
× ERROR → TypeError
i REASON → thisCountry.map is not a function
i ERROR STACK ↓ 
 TypeError: thisCountry.map is not a function
    at module.exports (C:\Users\lukel\Desktop\development\corona-cli\utils\getMultipleCountries.js:20:15)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async C:\Users\lukel\Desktop\development\corona-cli\index.js:67:2

[Shivathanu]

I have fixed this issue in the latest commit, thanks for mentioning. Kindly test and update.

[Shivathanu]

Thanks Luke for taking time to comment on the issue changes, have addressed your comments separately below each one of them.

[rsubtil]

When it is run in minimal/-m mode, it shows duplicated content:

$ corona-cli portugal,spain -m              
  
 #   Country     Cases        Cases (today)   Deaths      Deaths (today)   Recovered    Active       Critical   Per Million 
 →   Worldwide   42,847,157   383,248         1,153,216   4,503            31,602,038   10,091,903   76,918     5,497       
 —                                                                                                                          
  
 #   Country     Cases        Cases (today)   Deaths      Deaths (today)   Recovered    Active       Critical   Per Million 
 →   Worldwide   42,847,157   383,248         1,153,216   4,503            31,602,038   10,091,903   76,918     5,497       
 —                                                                                                                          
 —   Portugal    116,109      3,669           2,297       21               67,842       45,970       221        11,397      
 —   Spain       1,110,372    0               34,752      0                0            1,075,620    2,031      23,746