Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 1, 2025

discovered by new flake8 in
#10653

(cherry picked from commit 048ef4c)

discovered by new flake8 in
#10653

(cherry picked from commit 048ef4c)
@bdraco bdraco changed the title Remove useless nonlocal statements in tests (#10675) [PR #10675/048ef4c backport][3.12] Remove useless nonlocal statements in tests Apr 1, 2025
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Apr 1, 2025
@bdraco bdraco marked this pull request as ready for review April 1, 2025 21:42
@bdraco bdraco requested a review from asvetlov as a code owner April 1, 2025 21:42
@bdraco bdraco enabled auto-merge (squash) April 1, 2025 21:42
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #10678 will not alter performance

Comparing patchback/backports/3.12/048ef4c617130ef5a29a70ad67e34d9395891ac1/pr-10675 (5099a69) with 3.12 (d3c4543)

Summary

✅ 51 untouched benchmarks

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (d3c4543) to head (5099a69).
Report is 198 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #10678      +/-   ##
==========================================
+ Coverage   98.08%   98.10%   +0.01%     
==========================================
  Files         126      126              
  Lines       37607    37607              
  Branches     2131     2131              
==========================================
+ Hits        36886    36893       +7     
+ Misses        549      545       -4     
+ Partials      172      169       -3     
Flag Coverage Δ
CI-GHA 97.98% <ø> (+0.01%) ⬆️
OS-Linux 97.68% <ø> (+0.01%) ⬆️
OS-Windows 94.76% <ø> (+0.01%) ⬆️
OS-macOS 96.82% <ø> (+<0.01%) ⬆️
Py-3.10.11 96.71% <ø> (+0.29%) ⬆️
Py-3.10.16 97.26% <ø> (-0.01%) ⬇️
Py-3.11.11 97.33% <ø> (-0.05%) ⬇️
Py-3.11.9 96.80% <ø> (-0.02%) ⬇️
Py-3.12.9 97.77% <ø> (+0.87%) ⬆️
Py-3.13.2 97.76% <ø> (+0.26%) ⬆️
Py-3.9.13 96.59% <ø> (+<0.01%) ⬆️
Py-3.9.21 97.13% <ø> (+0.03%) ⬆️
Py-pypy7.3.16 93.93% <ø> (?)
VM-macos 96.82% <ø> (+<0.01%) ⬆️
VM-ubuntu 97.68% <ø> (+0.01%) ⬆️
VM-windows 94.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco closed this Apr 1, 2025
auto-merge was automatically disabled April 1, 2025 22:05

Pull request was closed

@bdraco bdraco reopened this Apr 1, 2025
@bdraco bdraco merged commit cca85c4 into 3.12 Apr 1, 2025
35 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/048ef4c617130ef5a29a70ad67e34d9395891ac1/pr-10675 branch April 1, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants