AML-4 Algo CLI Auth issue #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2021 16:14
kennydaniel
reviewed
Sep 21, 2021
Algorithmia/CLI.py
Outdated
| apikey = None | ||
| if('profiles' in config_dict.keys() and profile in config_dict['profiles'].keys()): | ||
| apikey = config_dict['profiles'][profile]['api_key'] | ||
| if config_dict['profiles'][profile]['api_key'] != "": |
Contributor
There was a problem hiding this comment.
This could be an and clause in the previous if.
kennydaniel
reviewed
Sep 21, 2021
kennydaniel
reviewed
Sep 21, 2021
kennydaniel
reviewed
Sep 21, 2021
| client = Algorithmia.client(CLI().getAPIkey(profile), CLI().getAPIaddress(profile), CLI().getCert(profile)) | ||
| result2 = CLI().ls("data://.my", client) | ||
|
|
||
| self.assertTrue(result2 != "") |
Contributor
There was a problem hiding this comment.
Be more specific about checking the result (not empty is a pretty loose test)
kennydaniel
previously approved these changes
Sep 21, 2021
Contributor
kennydaniel
left a comment
There was a problem hiding this comment.
Some nits, overall looks fine.
kennydaniel
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that the
algo authcommand bundled into the CLI will fail if the API Address is any cluster other than the Marketplace. This was isolated to line 34 of the CLI.py file and a test was added to (hopefully) ensure we catch issues like that in the future.