Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dark theme #431

Merged
merged 3 commits into from
Oct 30, 2021
Merged

Optimize dark theme #431

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
086e06b
Optimize dark theme
Edsuns Oct 18, 2021
a28aab3
Fix-up
Edsuns Oct 30, 2021
8f0fb39
Minor fixes
alshedivat Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimize dark theme
  • Loading branch information
@Edsuns
Edsuns committed Oct 18, 2021
commit 086e06be526ff4ccc9f9b866f19662176014269b
2 changes: 1 addition & 1 deletion _config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ impressum_path: # set to path to include impressum link in the footer, use the
# -----------------------------------------------------------------------------

navbar_fixed: true
footer_fixed: true
footer_fixed: false
Edsuns marked this conversation as resolved.
Show resolved Hide resolved

# Dimensions
max_width: 800px
Expand Down
20 changes: 14 additions & 6 deletions _sass/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ p, h1, h2, h3, h4, h5, h6, em, div, span, strong {
color: var(--global-text-color);
}

hr {
border-top: 1px solid var(--global-divider-color);
}

a, table.table a {
color: var(--global-theme-color);
&:hover {
Expand Down Expand Up @@ -91,18 +95,22 @@ blockquote {

.navbar {
box-shadow: none;
border-bottom: 1px solid $grey-color-light;
border-bottom: 1px solid var(--global-divider-color);
background-color: var(--global-bg-color);
opacity: 0.95;
}
.navbar .dropdown-menu {
background-color: var(--global-bg-color);
border: 1px solid var(--global-divider-color);
a:not(.active) {
color: var(--global-text-color);
}
a:hover {
color: var(--global-hover-color);
}
.dropdown-divider {
border-top: 1px solid var(--global-divider-color) !important;
}
}
.dropdown-item {
color: var(--global-text-color);
Expand Down Expand Up @@ -242,7 +250,7 @@ footer.fixed-bottom {
}

footer.sticky-bottom {
border-top: 1px solid $grey-color-light;
border-top: 1px solid var(--global-divider-color);
padding-top: 40px;
padding-bottom: 40px;
font-size: 0.9rem;
Expand All @@ -252,7 +260,7 @@ footer.sticky-bottom {
// Blog

.header-bar {
border-bottom: 1px solid $grey-color-light;
border-bottom: 1px solid var(--global-divider-color);
text-align: center;
padding-top: 2rem;
padding-bottom: 5rem;
Expand All @@ -267,7 +275,7 @@ footer.sticky-bottom {
margin-bottom: 40px;
padding: 0;
li {
border-bottom: 1px solid $grey-color-light;
border-bottom: 1px solid var(--global-divider-color);
list-style: none;
padding-top: 2rem;
padding-bottom: 2rem;
Expand Down Expand Up @@ -354,7 +362,7 @@ footer.sticky-bottom {

h2.category {
color: $grey-color-light;
border-bottom: 1px solid $grey-color-light;
border-bottom: 1px solid var(--global-divider-color);
padding-top: 0.5rem;
margin-top: 2rem;
margin-bottom: 1rem;
Expand Down Expand Up @@ -382,7 +390,7 @@ footer.sticky-bottom {
}
h2.year {
color: $grey-color-light;
border-top: 1px solid $grey-color-light;
border-top: 1px solid var(--global-divider-color);
padding-top: 1rem;
margin-top: 2rem;
margin-bottom: -2rem;
Expand Down
8 changes: 5 additions & 3 deletions _sass/_themes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
--global-text-color-light: #{$grey-color};
--global-theme-color: #{$purple-color};
--global-hover-color: #{$purple-color};
--global-footer-bg-color: #{$grey-color-dark};
--global-footer-bg-color: #{$dark-bg-color};
--global-footer-text-color: #{$grey-color-light};
--global-footer-link-color: #{$white-color};
--global-distill-app-color: #{$grey-color};
--global-divider-color: rgba(0,0,0,.1);

.fa-sun {
display : none;
Expand All @@ -25,16 +26,17 @@
}

html[data-theme='dark'] {
--global-bg-color: #{$grey-color-dark};
--global-bg-color: #{$dark-bg-color};
--global-code-bg-color: #{$code-bg-color-dark};
--global-text-color: #{$grey-color-light};
--global-text-color-light: #{$grey-color-light};
--global-theme-color: #{$cyan-color};
--global-hover-color: #{$cyan-color};
--global-footer-bg-color: #{$grey-color-light};
--global-footer-text-color: #{$grey-color-dark};
--global-footer-text-color: #{$dark-bg-color};
--global-footer-link-color: #{$black-color};
--global-distill-app-color: #{$grey-color-light};
--global-divider-color: #424246;

.fa-sun {
padding-left: 10px;
Expand Down
1 change: 1 addition & 0 deletions _sass/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ $black-color: #000000 !default;
$code-bg-color-light: rgba($purple-color, 0.05);
$code-bg-color-dark: #2c3237 !default;

$dark-bg-color: #1C1C1D;
Edsuns marked this conversation as resolved.
Show resolved Hide resolved