Added ability to specify tag names in selectors.#4368
Merged
avimehta merged 4 commits intoampproject:masterfrom Aug 18, 2016
Merged
Added ability to specify tag names in selectors.#4368avimehta merged 4 commits intoampproject:masterfrom
avimehta merged 4 commits intoampproject:masterfrom
Conversation
Contributor
|
@avimehta ready for review? |
Contributor
Author
Contributor
|
SG. Please ping when ready. |
Merged
If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
Contributor
Author
|
@dvoytenko this is ready for review. |
| * ancestor of the analytics element with that tag name is returned. | ||
| * | ||
| * @param {string} selector The selector for the element to track. | ||
| * @param {!HTMLElement} el Element whose ancestors to search. |
Contributor
There was a problem hiding this comment.
Just !Element: here and below
Added a property called `selectionMethod`. This property dictates how the selector is treated while searching for elements.
Contributor
Author
|
@dvoytenko ptal |
examples/analytics.amp.html
Outdated
| </amp-anim> | ||
| <amp-anim src="https://goo.gl/FBCKQO" id="anim-id" width="400" height="225" layout="responsive"> | ||
| <amp-img placeholder src="https://goo.gl/GjcSkr" width="400" height="225" layout="responsive"></amp-img> | ||
| <amp-analytics id="nestedAnalytics"> |
Contributor
|
LGTM with a couple more comments. |
Contributor
Author
|
@rudygalfi would you mind taking a look at the docs? |
avimehta
added a commit
to avimehta/amphtml
that referenced
this pull request
Aug 24, 2016
* Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Added ability to specify tag names in selectors. (ampproject#4368) * Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
mityaha
pushed a commit
to brightcove-archive/ooyala_amphtml
that referenced
this pull request
Nov 30, 2016
* Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
mityaha
pushed a commit
to brightcove-archive/ooyala_amphtml
that referenced
this pull request
Nov 30, 2016
* Added ability to specify tag names in selectors. (ampproject#4368) * Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a tag name is specified, an ancestor of the amp-analytics tag with
idetified by the tag name will be used for visibilitySpec.
Fixes #4018