Skip to content

Commit

Permalink
style(comments): added comments about moduleName
Browse files Browse the repository at this point in the history
Left a comment explaining why we don't want to use PLATFORM.moduleName here, although there are plenty of module names in the file.

See aurelia/pal#21
  • Loading branch information
jods4 committed Jan 19, 2017
1 parent 08e491c commit d2cb83e
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/framework-configuration.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,14 @@ export class FrameworkConfiguration {
return this;
}

// Default configuration helpers
// Note: Please do NOT add PLATFORM.moduleName() around those module names.
// Those functions are not guaranteed to be called, they are here to faciliate
// common configurations. If they are not called, we don't want to include a
// static dependency on those modules.
// Including those modules in the bundle or not is a decision that must be
// taken by the bundling tool, at build time.

/**
* Plugs in the default binding language from aurelia-templating-binding.
* @return Returns the current FrameworkConfiguration instance.
Expand Down

0 comments on commit d2cb83e

Please sign in to comment.