Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Missing Test Cases #1320

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update Missing Test Cases #1320

wants to merge 8 commits into from

Conversation

yongsuk44
Copy link
Contributor

What I have done and why

  • Add given for 'DynamicColorPreference' in SettingsViewModel
  • Add successful case for deleting RecentSearchQuery
  • Add successful case for setNewsResourceViewed

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

@yongsuk44
Copy link
Contributor Author

@JoseAlcerreca RFR :)

@yongsuk44
Copy link
Contributor Author

Fixed Issue - #1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaehwa-Noh Jaehwa-Noh Jaehwa-Noh left review comments

@hoc081098 hoc081098 hoc081098 left review comments

@JoseAlcerreca JoseAlcerreca JoseAlcerreca left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongsuk44 @JoseAlcerreca @hoc081098 @Jaehwa-Noh