Write Test Code In 'core.domain' package#1359
Open
squart300kg wants to merge 24 commits intoandroid:mainfrom
Open
Write Test Code In 'core.domain' package#1359squart300kg wants to merge 24 commits intoandroid:mainfrom
squart300kg wants to merge 24 commits intoandroid:mainfrom
Conversation
This reverts commit e1ee9b4.
… into Issue1327/ImproveDomainCoverage
… into Issue1327/ImproveDomainCoverage
Change-Id: I63e3f7ad009549a8673c61da59995c263526bbac
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Show resolved
Hide resolved
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...n/com/google/samples/apps/nowinandroid/core/testing/repository/TestRecentSearchRepository.kt
Show resolved
Hide resolved
Change-Id: Ia1d9049642e447d9233713a7e3ee593d0bd56930
Change-Id: I2a818503cffc458085e7aee04c2c12d9df532b3c
android#1327]) Change-Id: I392a1e3ebcbc8bc30623559d97c1657e5d50fbbc
…squart300kg/nowinandroid into Issue1327/ImproveDomainCoverage Change-Id: I9a779a4d11230dd849d1e961d3e572fc13c2002c
Contributor
Author
|
@JoseAlcerreca Thanks : ) |
SimonMarquis
reviewed
Apr 5, 2024
...kotlin/com/google/samples/apps/nowinandroid/core/domain/GetRecentSearchQueriesUseCaseTest.kt
Show resolved
Hide resolved
yongsuk44
reviewed
Apr 10, 2024
...n/com/google/samples/apps/nowinandroid/core/testing/repository/TestRecentSearchRepository.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Dec 19, 2024
...st/kotlin/com/google/samples/apps/nowinandroid/core/domain/GetFollowableTopicsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
Change-Id: I0df074b9d3b6161ff57e13f277d3af04babf3b27
Change-Id: I9e00d849b34bc6ff6390bdafd934740ab16172bf
Change-Id: I2ade29d0850206020ef69520f6e250de39dcef6d
Change-Id: I80c3c7132e87ba8d770f4eac9904671725b02265
Change-Id: I2201d548a4596f3040d81130f5ac53f29f7f034b
…bleList' to 'MutableSharedFlow' Change-Id: Ic7f914d5a3963812d0647a2f0b89f732f2d4188c
…7/ImproveDomainCoverage Change-Id: Ib862b1fc9f0044c86146206ae1c8ff9f1fe1571c # Conflicts: # core/testing/src/main/kotlin/com/google/samples/apps/nowinandroid/core/testing/repository/TestRecentSearchRepository.kt
Change-Id: If3ee12b2a4ddb3baec0e4e990b721526104dbc99
Jaehwa-Noh
reviewed
Dec 16, 2025
Contributor
Jaehwa-Noh
left a comment
There was a problem hiding this comment.
I think this naming is a better than previous name.
| ) | ||
|
|
||
| @Test | ||
| fun whenQueryLimitIsBy10_recentSearchQueriesAreReturnedUpTo10() = runTest { |
Contributor
There was a problem hiding this comment.
Suggested change
| fun whenQueryLimitIsBy10_recentSearchQueriesAreReturnedUpTo10() = runTest { | |
| fun query_overTen_showUpTenHistories() = runTest { |
| } | ||
|
|
||
| @Test | ||
| fun whenReceivingRecentSearchQueries_recentSearchQueriesAreReturnedInRecentOrder() = runTest { |
Contributor
There was a problem hiding this comment.
Suggested change
| fun whenReceivingRecentSearchQueries_recentSearchQueriesAreReturnedInRecentOrder() = runTest { | |
| fun query_overTen_showUpRecentTenResults() = runTest { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[What I have done and why]
write test code named 'GetRecentSearchQueriesUseCaseTest' in 'core.comain' package
[why i have done]
JoseAlcerreca raised issue numbered #1327.
[note]
#1327 issue completion need to write 3 class test code additionaly. Firstly, i write one class of them. so If this code is appropriate and merged, i will try one pull request containing the rest of 2 class test code.
if this code is inappropriate, please feed back for me. I will gladly accept your opinion. Thanks : )
Fixes #1327
How I'm testing it
Choose at least one:
Do tests pass?
DemoDebugvariant:./gradlew testDemoDebug./gradlew --init-script gradle/init.gradle.kts spotlessApplyIs this your first pull request?
./tools/setup.sh