Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: keyboard visible even after search screen is dismissed #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dinoy-raj
Copy link

What I have done and why

image

while navigating back to any of main tabs [ for you, saved, interest ] from seach screen
by clicking back icon button on top left, keyboard not hidden even after search screen fade out

keyboardjump1.webm
keyboardjumping3.webm

@Jaehwa-Noh
Copy link
Contributor

Jaehwa-Noh commented Apr 15, 2024

Same keyboardController in here line 479.
What about pass the keyboardController into SearchTextField as an argument?

@dinoy-raj
Copy link
Author

Same keyboardController in here line 479. What about pass the keyboardController into SearchTextField as an argument?

Thanks for the suggestion. I've made the corresponding changes in 6030c66

@dinoy-raj dinoy-raj marked this pull request as draft June 1, 2024 07:41
@dinoy-raj dinoy-raj marked this pull request as ready for review June 1, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants