-
Notifications
You must be signed in to change notification settings - Fork 694
Fix missing KEYCODE_HEADSETHOOK case #2779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…nnected_dispatchesEvent to include KEYCODE_MEDIA_PLAY_PAUSE & KEYCODE_HEADSETHOOK. Fixed a missing case for KEYCODE_HEADSETHOOK that caused the test above to fail.
fd75e08 to
d35c360
Compare
…HOOK result in correct calls on the player
74e960b to
1f5cbdb
Compare
|
@marcbaechinger Could you please take a look at this PR to confirm whether it fixes the issue or not? |
|
@SURAJ2600 @marcbaechinger I've release a version of my app with a local build of media3 with this changes, and it resolved my issues. Please note that there's only 2 lines of change in the production code, and one of them is an import. |
|
Can you please create a new PR from the |
|
@marcbaechinger Sure, sorry I missed that it was from the wrong branch. I'll work on that now. |
|
This PR was on the wrong branch. #2779 replaces it. Closing this one. |
|
#2816 is one that replaces it. |
Fixes #2768