Repository navigation
fix(app): confirm before disconnecting providers or removing accounts in settings - #64212
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks good. I checked it with the app's Playwright fixtures. On the base, Disconnect runs straight away. With this PR, a Disconnect OpenRouter? dialog with Cancel/Disconnect opens first. On the PR, both updated tests in settings.spec.ts pass, along with 15 of the other 16 providers: e2e tests. The other one ('a fresh install offers the Console sign-in') failed a focus check on the first run; the base hit the same cold-start failure on its first run. Against the base app code, both updated tests fail waiting for the dialog, so they catch the old one-click behaviour. tsc -b for packages/app is clean.
Public API: unchanged (only app UI and English strings).
No blocking concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Disconnect and Remove account in Settings › Providers ran on one click. Disconnect deletes every credential for the integration, and on the OpenCode Console row it drops every provider in the workspace. Both now ask first, in a dialog, the same way deleting a session does.
The connect dialog's own account removal already asks inline, so the two surfaces now match. No feature flag: it's a fix to a destructive action.
Evidence
After: a confirm dialog opens with Cancel focused; Cancel keeps the credentials, confirming removes them.
settings.spec.ts› "the account options rename and remove the active account" now cancels once (account stays, noDELETE /api/credential) then confirms (cred_workremoved). "a disconnect that finds no stored credentials…" confirms through the dialog. Both pass locally.Visual
Merge Danger
Door: two-way
Only adds a step before existing actions; reverting restores one-click behavior.
Blast Radius: small
Settings › Providers only. Any automation clicking Disconnect or Remove there now needs to confirm the dialog.