Skip to content

feat: adding more descriptive errors#3319

Merged
germa89 merged 16 commits intomainfrom
feat/more-descriptive-errors
Aug 8, 2024
Merged

feat: adding more descriptive errors#3319
germa89 merged 16 commits intomainfrom
feat/more-descriptive-errors

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 30, 2024

Description

More descriptive gRPC errors.

Issue linked

Close #2844
Close #3318

Checklist

@germa89 germa89 requested a review from a team as a code owner July 30, 2024 16:21
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 30, 2024 16:21
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Jul 30, 2024
@codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (a8b1514) to head (acf39fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3319      +/-   ##
==========================================
- Coverage   87.13%   87.10%   -0.03%     
==========================================
  Files          55       55              
  Lines        9773     9790      +17     
==========================================
+ Hits         8516     8528      +12     
- Misses       1257     1262       +5     

@germa89
Copy link
Collaborator Author

germa89 commented Aug 5, 2024

We won't care about coverage for this one.

@germa89 germa89 self-assigned this Aug 5, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Aug 8, 2024

Pinging @clatapie for review

@germa89
Copy link
Collaborator Author

germa89 commented Aug 8, 2024

traceback now looks:

Error:
MAPDL server connection terminated unexpectedly while running:
  SOLVE,
called by:
  _send_command_stream

Error:
  Socket closed
Full error:
<_MultiThreadedRendezvous of RPC that terminated with:
        status = StatusCode.UNAVAILABLE
        details = "Socket closed"
        debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:50062 {grpc_message:"Socket closed", grpc_status:14, created_time:"2024-08-08T19:09:47.964845+02:00"}"
>
Solve seems to have failed, retrieving .err files.
Traceback (most recent call last):
  File "/Users/german.ayuso/pymapdl/src/ansys/mapdl/core/errors.py", line 310, in wrapper
    out = func(*args, **kwargs)
  File "/Users/german.ayuso/pymapdl/src/ansys/mapdl/core/mapdl_grpc.py", line 2041, in _get
    getresponse = self._stub.Get(pb_types.GetRequest(getcmd=cmd))
  File "/Users/german.ayuso/pymapdl/.venv/lib/python3.10/site-packages/grpc/_channel.py", line 1176, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/Users/german.ayuso/pymapdl/.venv/lib/python3.10/site-packages/grpc/_channel.py", line 1005, in _end_unary_response_blocking
    raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
        status = StatusCode.UNAVAILABLE
        details = "failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:50062: recvmsg:Connection reset by peer"
        debug_error_string = "UNKNOWN:Error received from peer  {grpc_message:"failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:50062: recvmsg:Connection reset by peer", grpc_status:14, created_time:"2024-08-08T19:09:48.15481+02:00"}"

@germa89
Copy link
Collaborator Author

germa89 commented Aug 8, 2024

Again...

We won't care about coverage for this one.

I need this PR so...

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) August 8, 2024 18:53
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 75f2b7e into main Aug 8, 2024
@germa89 germa89 deleted the feat/more-descriptive-errors branch August 8, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing f string Array parameters retrieval fail when the size is very big

2 participants