Skip to content

feat: running MPI fix only if on windows#3575

Merged
germa89 merged 2 commits intomainfrom
feat/running-only-MPI-fix-on-windows
Nov 26, 2024
Merged

feat: running MPI fix only if on windows#3575
germa89 merged 2 commits intomainfrom
feat/running-only-MPI-fix-on-windows

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 25, 2024

Description

As the title. To simplify stuff.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 25, 2024 20:05
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 25, 2024 20:05
@germa89 germa89 self-assigned this Nov 25, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Nov 25, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Nov 25, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (853daba) to head (3e16ef1).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
- Coverage   86.93%   86.93%   -0.01%     
==========================================
  Files         187      187              
  Lines       14616    14622       +6     
==========================================
+ Hits        12707    12711       +4     
- Misses       1909     1911       +2     

@germa89 germa89 merged commit 4e93bf7 into main Nov 26, 2024
@germa89 germa89 deleted the feat/running-only-MPI-fix-on-windows branch November 26, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants