Skip to content

test: update test_deprecated_params to include make_block fixture to avoid plotting empty meshes error#4168

Merged
germa89 merged 5 commits intomainfrom
fix/plotting-empty-meshes-on-deprecate-param
Aug 8, 2025
Merged

test: update test_deprecated_params to include make_block fixture to avoid plotting empty meshes error#4168
germa89 merged 5 commits intomainfrom
fix/plotting-empty-meshes-on-deprecate-param

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 8, 2025

Description

Adding a mesh so we dont have a pyvista error.

Issue linked

Close #4167

Checklist

Copilot AI review requested due to automatic review settings August 8, 2025 07:55
@germa89 germa89 requested a review from a team as a code owner August 8, 2025 07:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates a test function to include a mesh fixture to prevent PyVista errors when plotting empty meshes. The change addresses issue #4167 by ensuring the test has actual mesh data to work with.

  • Add make_block fixture parameter to test_deprecated_params function

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Aug 8, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Aug 8, 2025

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) August 8, 2025 08:07
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (926287c) to head (2051dcb).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4168      +/-   ##
==========================================
+ Coverage   91.10%   91.31%   +0.20%     
==========================================
  Files         193      193              
  Lines       15722    15722              
==========================================
+ Hits        14323    14356      +33     
+ Misses       1399     1366      -33     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 merged commit de1cf18 into main Aug 8, 2025
80 of 81 checks passed
@germa89 germa89 deleted the fix/plotting-empty-meshes-on-deprecate-param branch August 8, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on CICD when plotting empty meshes

4 participants