fix: replace deprecated numpy in1d with isin for array comparison#4356
Merged
fix: replace deprecated numpy in1d with isin for array comparison#4356
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the deprecated NumPy in1d function with its recommended replacement isin for array membership testing, addressing issue #4355.
Key Changes:
- Updated array comparison logic to use the modern NumPy API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4356 +/- ##
==========================================
- Coverage 91.32% 91.26% -0.06%
==========================================
Files 195 196 +1
Lines 15969 15977 +8
==========================================
- Hits 14584 14582 -2
- Misses 1385 1395 +10 🚀 New features to boost your workflow:
|
clatapie
pushed a commit
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Issue linked
Close #4355
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)