Skip to content

fix: consider packages key existence in pnpm-workspace.yaml#78

Merged
antfu merged 1 commit intoantfu-collective:mainfrom
sushichan044:fix/consider-pnpm-workspace-yaml-without-oackages
May 16, 2025
Merged

fix: consider packages key existence in pnpm-workspace.yaml#78
antfu merged 1 commit intoantfu-collective:mainfrom
sushichan044:fix/consider-pnpm-workspace-yaml-without-oackages

Conversation

@sushichan044
Copy link
Copy Markdown
Contributor

@sushichan044 sushichan044 commented Apr 16, 2025

This PR allows bumpp to work properly in repositories where pnpm-workspace.yaml exists but not in a mono-repo configuration.

Description

In the latest version of pnpm, settings that were previously written under pnpm in package.json are now written in pnpm-workspace.yaml, as shown below.

onlyBuiltDependencies:
  - esbuild

patchedDependencies:
  bumpp: patches/bumpp.patch

Therefore, even if pnpm-workspace.yaml exists, it may not have a packages key.
So we must consider the case where the packages key is missing

Linked Issues

Additional context

@sushichan044 sushichan044 force-pushed the fix/consider-pnpm-workspace-yaml-without-oackages branch from 225b67f to a9731ee Compare April 16, 2025 16:35
@antfu antfu merged commit 213aa47 into antfu-collective:main May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants