fix: consider packages key existence in pnpm-workspace.yaml#78
Merged
antfu merged 1 commit intoantfu-collective:mainfrom May 16, 2025
Conversation
225b67f to
a9731ee
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows bumpp to work properly in repositories where pnpm-workspace.yaml exists but not in a mono-repo configuration.
Description
In the latest version of pnpm, settings that were previously written under
pnpminpackage.jsonare now written inpnpm-workspace.yaml, as shown below.Therefore, even if
pnpm-workspace.yamlexists, it may not have apackageskey.So we must consider the case where the packages key is missing
Linked Issues
Additional context