fix: console.error emit from grid line plugin when followZoom is on #7289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a console.error in the grid-line plugin that occurs when followZoom is enabled. The fix introduces a guard to prevent getCanvasCenter from being called before the viewport is initialized. A suggestion was made to make the implementation more robust by checking for both null and undefined values for the origin and using the nullish coalescing operator (??) for safer default value assignment.
hustcc
reviewed
Jul 29, 2025
Member
|
@louisch 麻烦 pr 描述中来一个验证的截图或者 gif 吧 |
Aarebecca
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a console.error that is emit when follow.zoom is turned on in the grid-line plugin
Reproduction sandbox for this bug here: https://stackblitz.com/edit/g6-v5-gridline-getcanvascenter-error?file=src%2FApp.tsx
The error happens because when getCanvasCenter is called, this.context.viewport may not be defined, so an error is thrown.