feat: title plugin #7294
Merged
feat: title plugin #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
c766f64 to
7796cf1
Compare
hustcc
reviewed
Jul 22, 2025
hustcc
reviewed
Jul 22, 2025
hustcc
reviewed
Jul 22, 2025
hustcc
reviewed
Jul 22, 2025
hustcc
reviewed
Jul 22, 2025
hustcc
reviewed
Jul 23, 2025
| } | ||
|
|
||
| return [title, subTitle]; | ||
| } |
Member
There was a problem hiding this comment.
这个写法不太符合 G component 的写法。G component 有点类似于 React。
伪代码如下：
class TitleComponent extends CustomElement<T> {
constructor(config: DisplayObjectConfig<T>) {
super(config);
}
connectedCallback() {
}
public update(cfg = {}) {
this.attr(deepMix({}, this.attributes, cfg));
}
render(attributes, container) {
this.add(titleLabel);
this.add(subtitleLabel);
}
};
Aarebecca
reviewed
Jul 30, 2025
| } | ||
|
|
||
| export class Title extends BasePlugin<TitleOptions> { | ||
| private static commonStyle: Partial<LabelStyleProps> = { |
Contributor
There was a problem hiding this comment.
这个定义到外部常量就可以了，避免在类上挂载无关的变量和方法
| Used to configure the horizontal alignment of the title plugin. Default is `left`. You can choose `left`, `center`, or `right`, representing left-aligned, center-aligned, and right-aligned respectively. | ||
|
|
||
| ```js | ob { pin: false } | ||
| createGraph( |
Collaborator
Author
There was a problem hiding this comment.
这里要用playerplayground
5b53b76 to
5f96bca
Compare
Aarebecca
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.