feat: Optionally set the schema for table creation#66
Merged
hsluoyz merged 4 commits intoapache:masterfrom Sep 21, 2022
Merged
Conversation
In postgres the table can be created under different schemas and not just "public"
|
@nodece @Zxilly @Shivansh-yadav13 please review |
|
|
Member
|
@nodece @Zxilly @Shivansh-yadav13 please review |
Contributor
Author
|
@hsluoyz had a lint error, I fixed it |
Pull Request Test Coverage Report for Build 3083837725
💛 - Coveralls |
Contributor
|
lgtm, but please follow semantic commit rules. |
Shivansh-yadav13
pushed a commit
to Shivansh-yadav13/sequelize-adapter
that referenced
this pull request
Sep 21, 2022
* Optionally set the schema for table creation In postgres the table can be created under different schemas and not just "public" * updated readme * fix - description * fix - format
js-lowes
added a commit
to js-lowes/sequelize-adapter
that referenced
this pull request
Sep 21, 2022
hsluoyz
pushed a commit
that referenced
this pull request
Sep 22, 2022
* feat: Add in schema in previos PR: #66 * fix: Require a frozen lockfile when build "--frozen-lockfile" will make it so that the yarn build process is reproducible and uses the versions of dependencies defined in the "yarn.lock" file.
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support to optionally set the schema for table
Why?
Some RDBMS support the idea of
schemabeing a separated namespace under a database, e.g. Postgres.What was changed?
schemaoption to the table creation exactly howtableNamewas propagated.