feat: Optionally skip create table with argument to newAdapter#71
Closed
rogersgt wants to merge 2 commits intoapache:masterfrom
Closed
feat: Optionally skip create table with argument to newAdapter#71rogersgt wants to merge 2 commits intoapache:masterfrom
rogersgt wants to merge 2 commits intoapache:masterfrom
Conversation
|
@nodece @Zxilly @Shivansh-yadav13 please review |
Pull Request Test Coverage Report for Build 4056270362
💛 - Coveralls |
hsluoyz
requested changes
Feb 1, 2023
| private autoCreate = true; | ||
|
|
||
| constructor(option: SequelizeAdapterOptions) { | ||
| constructor(option: SequelizeAdapterOptions, autoCreate = true) { |
| @@ -47,9 +49,10 @@ export class SequelizeAdapter implements Adapter { | |||
| * @param option sequelize connection option | |||
| */ | |||
| public static async newAdapter( | |||
Member
There was a problem hiding this comment.
Add the new usage to README.md
Member
Member
|
@rogersgt hi, can you fix the issues according to the review? |
Member
|
Replaced by: #73 |
Contributor
Author
|
Sorry for the delay here. Thanks for making the change @terry-xuan-gao! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: apache/casbin-node-casbin#418
See my question int he issues section of the
node-casbinrepo: apache/casbin-node-casbin#418. If there is already a way to do this, or a better pattern, I'm all for it. But I really think this is needed for many enterprise implementations.