Skip to content

add healthcheck router#389

Merged
AlexStocks merged 10 commits intoapache:developfrom
CodingSinger:HEALTH_CHECK
Mar 7, 2020
Merged

add healthcheck router#389
AlexStocks merged 10 commits intoapache:developfrom
CodingSinger:HEALTH_CHECK

Conversation

@CodingSinger
Copy link
Copy Markdown
Member

No description provided.

@CodingSinger
Copy link
Copy Markdown
Member Author

refer #337

@CodingSinger CodingSinger requested a review from zouyx March 4, 2020 12:52
@zouyx zouyx requested a review from flycash March 4, 2020 13:54
Copy link
Copy Markdown
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have last question, must healthcheck router relate to condition router? if not ,you can add new package in router package,like healthcheck?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 5, 2020

Codecov Report

Merging #389 into develop will increase coverage by 0.19%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #389      +/-   ##
==========================================
+ Coverage     67.1%   67.3%   +0.19%     
==========================================
  Files          157     161       +4     
  Lines         8244    8331      +87     
==========================================
+ Hits          5532    5607      +75     
- Misses        2191    2201      +10     
- Partials       521     523       +2
Impacted Files Coverage Δ
cluster/router/healthcheck/default_health_check.go 100% <100%> (ø)
protocol/rpc_status.go 72.22% <100%> (+3.96%) ⬆️
common/extension/health_checker.go 66.66% <66.66%> (ø)
cluster/router/healthcheck/factory.go 66.66% <66.66%> (ø)
cluster/router/healthcheck/health_check_route.go 68% <68%> (ø)
protocol/dubbo/client.go 67.87% <0%> (-1.22%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989c001...91830f5. Read the comment docs.

Copy link
Copy Markdown
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and add samples

@AlexStocks
Copy link
Copy Markdown
Contributor

LGTM

@AlexStocks AlexStocks merged commit ab850a4 into apache:develop Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants