fix: add identifier-field-ids JSON serialization/deserialization #451
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ccd3f0 to
08b1863
Compare
- Add serialization of identifier-field-ids in ToJson(Schema) - Add deserialization of identifier-field-ids in SchemaFromJson() - Add comprehensive test coverage for: * Schema with single identifier field * Schema without identifier fields * Schema with multiple identifier fields * Round-trip serialization/deserialization Fixes the TODO in json_internal.cc for identifier-field-ids support.
08b1863 to
797e888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the TODO in json_internal.cc for identifier-field-ids support.