Replace old %-formatted by f-strings#93
Merged
Fokko merged 2 commits intoapache:mainfrom Oct 23, 2023
Merged
Conversation
Fokko
reviewed
Oct 21, 2023
| ] | ||
| additional_dependencies: | ||
| - tomli==2.0.1 | ||
| - repo: https://github.com/ikamensh/flynt |
Contributor
There was a problem hiding this comment.
Instead of adding a new plugin, can you enable the check in Ruff? https://docs.astral.sh/ruff/rules/#flynt-fly
Member
Author
There was a problem hiding this comment.
Yes, I will check it.
Member
Author
There was a problem hiding this comment.
The implementation of Flynt in ruff is still in progress (astral-sh/ruff#2102), the current rule doesn't detect all the usages of the old styles, and I cannot provide the argument line-length to deal with long lines. WDYT?
Contributor
There was a problem hiding this comment.
Thanks, I was unaware of that. I ran it locally, and it didn't pick up the violations that are caught here.
Fokko
reviewed
Oct 21, 2023
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Great suggestion @hussein-awala 🙌
Fokko
approved these changes
Oct 23, 2023
%-formatted by f-strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace old %-formatted by f-strings and add
flynthook to pre-commit to auto-detect and fix them.