Measure Time to First byte in JDBCSampler#211
Closed
tpeyrard wants to merge 2 commits intoapache:trunkfrom
Closed
Conversation
- Use connect time to instead of latency to measure connection time - Use latency to measure the time at which the first ResultSet (or whatever) is received from the connection
Author
|
I'm not sure the failing build is related to my commit. I had the error before my change. |
| /** | ||
| * Use the sample given as argument to set time to first byte in the "latency" field of the SampleResult. | ||
| */ | ||
| protected byte[] execute(Connection conn, SampleResult sample) throws SQLException, IOException { |
Contributor
There was a problem hiding this comment.
The javadoc could (should) have documentation for the params, return value, ...
It looks a bit strange, that execute(conn) throws UnsupportedOperationException, but this method does not.
Contributor
|
The SNI test is quite flaky, but as you suspected, that is not your fault. |
Author
…dEncodingException because the IOException is more general. Add javadoc for execute method taking a sample as argument.
Author
|
Hello, I couldn't figure out whether the job fails because of my changes or not. Any idea? Thanks |
Contributor
|
The jobs fail because of the flaky sni test. They are not your fault. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hello,
I use JMeter to measure performance of a database. When executing queries returning a lot of rows, the time taken by JMeter to read the ResultSet and storing the result in a StringBuilder then calling toString() might be bigger than the execution time on the server.
In order to easily understand what's taking time for slow queries, I thought it might be interesting to use "Latency" and "Connect Time" of the SampleResult to show two informations:
What do you think of that change?
Regards,
Thomas