Closed
Conversation
added 4 commits
January 4, 2017 12:18
These tests only work with the apache#237 PR merged and timed mode box
Contributor
|
Hello,
Also would it be possible to provide:
I have already made some changes to PR, I could commit it as is and mark component as Alpha, we could distribute with next release and improve it either before or later. |
|
I use an AsyncHTTP thread pool to send to InfluxDB from a custom listener.
Works very well.
…Sent from my iPhone
On Jan 15, 2017, at 10:33 AM, Philippe M ***@***.***> wrote:
Hello,
Thanks for contribution.
I have few remarks on implementation:
You intentionally don't set timestamp. I am not sure it's a good idea as if any delay occurs sending to InfluxDB, measurement will be wrong, and there is another reason, see next remark
I think HttpAsyncClient (https://hc.apache.org/httpcomponents-asyncclient-dev/quickstart.html) might be a good use case here as we don't care about responses and we don't want to block too much, so we could use it here. But in this case we would need to add timestamp.
I think you should allow some configuration for technical things like timeouts. InfluxdbMetricsSender#setup should have a more flexible parameter like Map to allow passing more parameters
Also would it be possible to provide:
A Simple Test plan using the component
If possible some documentation
I have already made some changes to PR, I could commit it as is and mark component as Alpha, we could distribute with next release and improve it either before or later.
@Team what do you think ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
Hi Mark, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new backend listener to send data to InfluxDB server. InfluxDB is a time series database built to handle high write and query loads.
This backend write data with the HTTP API based on the influxdb line protocol.
See :
HTTP API
Line protocol reference
Syntax example :
<measurement>[,<tag_key>=<tag_value>[,<tag_key>=<tag_value>]] <field_key>=<field_value>[,<field_key>=<field_value>] [<timestamp>]At the start and the end of a JMeter test, the backend add automaticaly two annotations in the
annotationmeasurement for a better usage with Grafana ( See grafana documentation