Utilising more modern Java, simplifying code and formatting code and comments#327
Closed
ham1 wants to merge 3 commits intoapache:trunkfrom
ham1:formatting_whitespace_etc
Closed
Utilising more modern Java, simplifying code and formatting code and comments#327ham1 wants to merge 3 commits intoapache:trunkfrom ham1:formatting_whitespace_etc
ham1 wants to merge 3 commits intoapache:trunkfrom
ham1:formatting_whitespace_etc
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #327 +/- ##
============================================
+ Coverage 57.83% 57.87% +0.03%
+ Complexity 9937 9935 -2
============================================
Files 1141 1141
Lines 73217 73166 -51
Branches 7305 7277 -28
============================================
- Hits 42346 42342 -4
+ Misses 28405 28356 -49
- Partials 2466 2468 +2
Continue to review full report at Codecov.
|
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2017
…comments This comment #327 (PART 1) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1815391 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2017
…comments This comment #327 (PART 2) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1815392 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three commits covering three types of change:
Feel free to take only some, I did this while trying to better understand the code.
Motivation and Context
Improve readability etc.
How Has This Been Tested?
Ant test, no functional changes.
Screenshots (if appropriate):
Types of changes
Checklist: