Tidy JavaDoc and fix error in getTop5ErrorMetrics method.#337
Closed
ham1 wants to merge 1 commit intoapache:trunkfrom
ham1:top_5_error_bug
Closed
Tidy JavaDoc and fix error in getTop5ErrorMetrics method.#337ham1 wants to merge 1 commit intoapache:trunkfrom ham1:top_5_error_bug
ham1 wants to merge 1 commit intoapache:trunkfrom
ham1:top_5_error_bug
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #337 +/- ##
===========================================
+ Coverage 57.9% 57.91% +<.01%
- Complexity 10023 10025 +2
===========================================
Files 1148 1148
Lines 73798 73792 -6
Branches 7331 7329 -2
===========================================
+ Hits 42732 42735 +3
+ Misses 28587 28578 -9
Partials 2479 2479
Continue to review full report at Codecov.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug whereby calling
registerErrorwith the following data set["A", "B", "C", "D", "E", "F"]would return[["A", 1], [null, null], [null, null], [null, null], [null, null]]instead of[["A", 1], ["B", 1], ["C", 1], ["D", 1], ["E", 1]].Improved JavaDoc for
registerErrorAlso removed JavaDoc which did not add anything to the method names.
Motivation and Context
Made the code more readable and at the same time fixed a subtle error.
How Has This Been Tested?
On my spock branch:
Screenshots (if appropriate):
Types of changes
Checklist: