Closed
Conversation
Contributor
|
Thanks for your contribution. |
Contributor
|
Some discussion about the performance impact of the log messages has taken place on the dev mailing list. Would this patch be still useful for you, if we logged the messages at debug or info level? |
Author
|
Thanks to you for accepting this change. Naturally It would be still useful at info or debug level: the important point imho is to see the complete stacktrace when a test throws an exception. |
asfgit
pushed a commit
that referenced
this pull request
Feb 18, 2018
Part of #376 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1824658 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logging of any non-assert exception generated inside a test.
Motivation and Context
The main motivation is to speedup fixing of errors inside test methods. We have a big test suite that
is run using the JUnitSampler using this pattern:
With this change the code would be simpler:
How Has This Been Tested?
Still to be tested. Since we are using jmeter-maven-plugin, we need to install the JMeter core in the local maven repository. There is a quick way to do this using ant?
Types of changes
Checklist: