Skip to content

Improve a few unit tests and classes#451

Closed
ham1 wants to merge 7 commits intoapache:trunkfrom
ham1:improve_unit_tests
Closed

Improve a few unit tests and classes#451
ham1 wants to merge 7 commits intoapache:trunkfrom
ham1:improve_unit_tests

Conversation

@ham1
Copy link
Contributor

@ham1 ham1 commented Feb 25, 2019

Description

  • Formatting of SampleComparator and FieldSampleComparator
  • Moved TestDNSCacheManager to Spock
  • Formatted and refactored some parts of DNSCacheManager
  • Added more tests for FieldSampleComparatorSpec

How Has This Been Tested?

ant clean test-headless -Drmi_force_localhost=true

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (trunk@be3271f). Click here to learn what that means.
The diff coverage is 83.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##             trunk     #451   +/-   ##
========================================
  Coverage         ?   58.71%           
  Complexity       ?    10818           
========================================
  Files            ?     1209           
  Lines            ?    77304           
  Branches         ?     7466           
========================================
  Hits             ?    45389           
  Misses           ?    29373           
  Partials         ?     2542
Impacted Files Coverage Δ Complexity Δ
.../report/processor/FieldSampleComparatorSpec.groovy 100% <100%> (ø) 4 <3> (?)
...jmeter/report/processor/FieldSampleComparator.java 100% <100%> (ø) 3 <1> (?)
.../jmeter/protocol/http/control/DNSCacheManager.java 74.05% <60%> (ø) 37 <6> (?)
...r/protocol/http/control/DNSCacheManagerSpec.groovy 91.35% <91.35%> (ø) 13 <13> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3271f...7faa6f2. Read the comment docs.

@asfgit asfgit closed this in dd79995 Feb 26, 2019
@ham1 ham1 deleted the improve_unit_tests branch February 26, 2019 21:19
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants