Add jsonpath string to jsonpath assertion error message#5717
Closed
lehmannk wants to merge 2 commits intoapache:masterfrom
Closed
Add jsonpath string to jsonpath assertion error message#5717lehmannk wants to merge 2 commits intoapache:masterfrom
lehmannk wants to merge 2 commits intoapache:masterfrom
Conversation
vlsi
requested changes
Oct 19, 2022
Collaborator
vlsi
left a comment
There was a problem hiding this comment.
The change looks good to me, however, please change the other throw statements in doAssert method in the same manner.
d3ad3cc to
e0136c0
Compare
…nderstand the error
e0136c0 to
cb3455e
Compare
Author
|
modified the requested statements and fixed unit tests accordingle |
vlsi
requested changes
Oct 29, 2022
src/components/src/main/java/org/apache/jmeter/assertions/JSONPathAssertion.java
Show resolved
Hide resolved
src/components/src/main/java/org/apache/jmeter/assertions/JSONPathAssertion.java
Outdated
Show resolved
Hide resolved
…PathAssertion.java Co-authored-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
Author
|
Hi @vlsi can you finally approve this PR? All your requested changes are incorporated. |
vlsi
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the jsonpath string to the jsonpath assertion error message so it is easier to understand the actual error.
Motivation and Context
Currently, the jsonpath error produced when a mismatch occurs is not easy to understand because it does not contain the underlying analyzed jsonpath.
Example:
There is no way to understand what is expected to be 'true' here.
Thus, the actual jsonpath which caused the error shall be added, example:
How Has This Been Tested?
tested locally
Screenshots (if appropriate):
Types of changes
Checklist: