Update HTML parser to pick up preload attribute for rel#5947
Closed
matthewt-assurity wants to merge 1 commit intoapache:masterfrom
Closed
Update HTML parser to pick up preload attribute for rel#5947matthewt-assurity wants to merge 1 commit intoapache:masterfrom
preload attribute for rel#5947matthewt-assurity wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
This is my first time contributing to JMeter, is there any documentation that should be updated for this change? |
Collaborator
|
Do you think you could update https://github.com/apache/jmeter/blob/master/xdocs/changes.xml as well? |
Collaborator
|
Merged in 6d6479b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated JMeter HTML parsers to pick up on the
preloadvalue for therelattribute in<link>tags.A constant has been added to
HTMLParser.javafor the preload value. The parser implementation classes have been updated to use this constant.Motivation and Context
During a project we found some embedded resource files that were not being downloaded by default. To address this in the meantime we have used the parallel sampler extension. We found that the problem was the
preloadvalue wasn't being picked up as a valid value in the JMeter HTML parsers, so I am proposing that this becomes part of the HTML parsers.I am unaware of any open issue for this.
How Has This Been Tested?
./gradlew runGuihas been run, and a simple test hitting an HTML page withrel=preloadattributes was run../gradlew checkhas been run and passes.Types of changes
Checklist: