Add freestyle naming scheme to proxy samples

[FSchumacher]

Description

This is a slightly different approach to naming samples that are recorded via the proxy that has been proposed in #571.

Motivation and Context

I think as we add another scheme to naming recorded samples, others will want their favourite naming schemes, too. So in this PR I try to anticipate that by adding a format string that can be used to go really wild on your naming preferences. (The newly added suffix-mode can be expressed through the format string, as well as the older modes prefix and transaction)

The PR #571 has one other feature, that is not implemented in this PR. Namely the addition of setting starting numbers for recorded samples. I think that should be added in another feature/PR. It is of course possible to add it later with this approach, too.

How Has This Been Tested?

Currently it has only been tested via GUI. No tests have been added.

Screenshots (if appropriate):

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.

[vlsi]

Thanks for implementing this. I agree it would be better to make the format configurable rather than implementing a couple of hard-coded formats.

I'm not sure MessageFormat is a proper templating framework though: there are no named parameters, so the template string would be awkward and it would be hard to reason about :-/

[FSchumacher]

...

I'm not sure MessageFormat is a proper templating framework though: there are no named parameters, so the template string would be awkward and it would be hard to reason about :-/

Yes, I agree. MessageFormat might be hard to read, but

• it is better then my first implementation, which used String#format which sucked even more ;)
• it can use formatting options for numbers, which is handy, as it allows something like {1,number,000}
• other template languages might look like the JMeter built-in variable replacement syntax or would have to be included (for the former I thought about StringSubstitutor from commons-text)

Do you have a special templating system in mind, that we can/should use?

One idea would be to parse the format string and generate the three placeholders à la #{prefix} #{path} #{count,number,000} -> {0} {1} {2,number,000} via s/#{count\b/{2/, etc.

[FSchumacher]

Despite of my initial comment, I have implemented the counter feature from #571 in this PR. Apart from the documentation (which is still missing), it looks complete now.

[pmouawad]

Hello @FSchumacher ,
This PR looks good to me.
Thanks
Regards

[vdaburon]

How can i set the format for numbering in the jmeter.propeties or user.properties ?

I don't see a property to set the format.

numbering.format?=#{counter,number,000} #{path}

Regards

[FSchumacher]

In the string format, you can use #{counter,number,000} directly. So, if you want to use the counter with three digits then a dash, the path and the transaction name in parenthesis, you would write #{counter,number,000} - #{path} (#{name}) in the text field next to the select field Naming scheme where you selected Use format string.
You don't set any property.

[vdaburon]

How can i set the default format for recording and multi-computers ?

Usually you could set the default value in the jmeter.properties. I don't see this feature.

But I appreciate the new interface with the possibility to choose the numbering format and set the counter value.

Regards.

[FSchumacher]

I have added a JMeter property (proxy.sampler_format in bin/jmeter.properties), that can be used to choose a default value.

[vdaburon]

I download,the nigthly jmeter (2020-09-01).

When i use the template "Recording", i see the format that i set in the jmeter.properties
proxy.sampler_format=#{counter,number,000} #{path}

but when i don't use a template and add manually a "HTTP(S) Test Script Recorder", i don't see any format from proxy.sampler_format

Regards

[FSchumacher]

Can you try again?