Ensure all buttons added to the toolbar behave/look consistently.#599
Merged
pmouawad merged 1 commit intoapache:masterfrom Jun 24, 2020
Merged
Ensure all buttons added to the toolbar behave/look consistently.#599pmouawad merged 1 commit intoapache:masterfrom
pmouawad merged 1 commit intoapache:masterfrom
Conversation
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure all buttons added to the toolbar behave and look consistently.
Motivation and Context
Some plugins add own buttons to the toolbar e.g. JMeter Plugin.
Because those most likely aren't configured the same way the other buttons are they look/feel out of place.
This PR ensures that buttons in the toolbar are
Ideally there should be an API for plugin developers to add own buttons to the toolbar (Is there already?). Right now the icons are located at the end of the toolbar instead of the designated button area.
How Has This Been Tested?
See screenshots.
Screenshots (if appropriate):
Visually this only makes a difference with Darklaf.
Before:
After:
Types of changes
Checklist: