fix: use default value for LoopController.continue_forever rather than initializing it in the constructor#6011
Merged
vlsi merged 2 commits intoapache:masterfrom Jun 28, 2023
Merged
Conversation
…itializing in the constructor Previously LoopController initialized continue_forever=true in the constructor, however, and ThreadGroup.setMainController flipped the value to false. It caused inconsistency since non-GUI launch does not call ThreadGroup.setMainController. Using default=true enables to treat "false" as non-standard, so =false is saved t the jmx, and it gets loaded in non-GUI as well. Fixes apache#6008
…load roundtrip ProxyControl initialized collection properties with HashSet which caused CollectionProperty.equals to return false. CollectionProperty is normalized to ArrayList on save, so we should not pass HashSet to the CollectionProperty in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously LoopController initialized continue_forever=true in the constructor, however, and ThreadGroup.setMainController flipped the value to false.
It caused inconsistency since non-GUI launch does not call ThreadGroup.setMainController.
Using default=true enables to treat "false" as non-standard, so =false is saved t the jmx, and it gets loaded in non-GUI as well.
Fixes #6008