Closed
Conversation
Observed a few changes. Suggesting the same. Kindly check.
FSchumacher
reviewed
Aug 19, 2020
Contributor
FSchumacher
left a comment
There was a problem hiding this comment.
Thanks for spell-checking, even if I am not 100 % sure, that we should use all of these (especially not the may be one).
|
|
||
| The following provides more details on the included software that | ||
| may be subject to export controls on cryptographic software: | ||
| maybe subject to export controls on cryptographic software: |
Contributor
There was a problem hiding this comment.
I am pretty sure, that may be is correct here.
| - Data analysis and **visualization plugins** allow great extensibility and personalization. | ||
| - Functions can be used to provide dynamic input to a test or provide data manipulation. | ||
| - Easy Continuous Integration via 3rd party Open Source libraries for Maven, Gradle and Jenkins. | ||
| - Easy Continuous Integration via 3rd party Open Source libraries for Maven, Gradle, and Jenkins. |
Contributor
There was a problem hiding this comment.
Have you had a look at all the other places, where we don't follow the rule to place a comma before and when spelling out lists?
ham1
pushed a commit
to ham1/jmeter
that referenced
this pull request
Sep 13, 2020
Based on patches by Pooja Chandak (poojachandak002 at gmail.com) Closes apache#612
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
Based on patches by Pooja Chandak (poojachandak002 at gmail.com) Closes apache#612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed a few changes. Suggesting the same. Kindly check.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: