Bolt Sampler - Neo4j 4.x and cluster features#638
Closed
pecollet wants to merge 15 commits intoapache:masterfrom
Closed
Bolt Sampler - Neo4j 4.x and cluster features#638pecollet wants to merge 15 commits intoapache:masterfrom
pecollet wants to merge 15 commits intoapache:masterfrom
Conversation
database : required to address a on-default dtabase in Neo4j 4.x accessMode : allow to test against a cluster w/o having all queries sent to the leader (previous was defaulting to WRITE)
- new tx timeout option - fixed results consumption issue in 4.x - separated options from query in UI + better descriptions
FSchumacher
reviewed
Dec 15, 2020
Contributor
FSchumacher
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think it will have to wait until the release 5.4.1, which should happen soon.
...ocol/bolt/src/main/java/org/apache/jmeter/protocol/bolt/sampler/AbstractBoltTestElement.java
Outdated
Show resolved
Hide resolved
src/protocol/bolt/src/main/java/org/apache/jmeter/protocol/bolt/sampler/BoltSampler.java
Outdated
Show resolved
Hide resolved
...t/src/main/resources/org/apache/jmeter/protocol/bolt/sampler/BoltSamplerResources.properties
Outdated
Show resolved
Hide resolved
...lt/src/main/java/org/apache/jmeter/protocol/bolt/sampler/BoltTestElementBeanInfoSupport.java
Outdated
Show resolved
Hide resolved
...ocol/bolt/src/main/java/org/apache/jmeter/protocol/bolt/sampler/AbstractBoltTestElement.java
Outdated
Show resolved
Hide resolved
also removed time assertions that made some unit tests flaky
update to latest JMeter
Allows to specify a pool size larger than the default 100, which can become a bottleneck with large number of threads using a single Neo4j driver. Also improve Bolt URI description to describe neo4j:// format.
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
============================================
+ Coverage 55.43% 55.45% +0.01%
- Complexity 10155 10163 +8
============================================
Files 1044 1044
Lines 64078 64127 +49
Branches 7250 7252 +2
============================================
+ Hits 35524 35559 +35
- Misses 26047 26061 +14
Partials 2507 2507 Continue to review full report at Codecov.
|
ham1
reviewed
Jan 9, 2021
...ocol/bolt/src/main/java/org/apache/jmeter/protocol/bolt/sampler/AbstractBoltTestElement.java
Outdated
Show resolved
Hide resolved
also updated the docs of the Bolt Sampler and Bolt config to reflect the new parameters
Contributor
|
Thanks for the PR. Can you test the next nightly or build from trunk? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bolt Sampler :
Motivation and Context
Enables running JMeter against Neo4j 4.0, 4.1 & 4.2.
Enables running JMeter against Neo4j Enterprise Causal clusters
Enables setting a limit on request execution time.
How Has This Been Tested?
Tested against : 3.5 standalone Neo4j instance, 3.5 Causal Cluster, 4.2 standalone Neo4j instance, 4.2 Causal Cluster.
Test config : 1 "Bolt Connection Configuration" + 1 "Bolt Request" in a Thread group
Screenshots (if appropriate):
Types of changes
Checklist: