Skip to content

Increase visible lines of code in IfController and WhileController#665

Closed
dgetzlaf wants to merge 1 commit intoapache:masterfrom
dgetzlaf:more-visible-lines-for-if-and-whilecontroller
Closed

Increase visible lines of code in IfController and WhileController#665
dgetzlaf wants to merge 1 commit intoapache:masterfrom
dgetzlaf:more-visible-lines-for-if-and-whilecontroller

Conversation

@dgetzlaf
Copy link
Contributor

@dgetzlaf dgetzlaf commented May 19, 2021

Increase the visible lines of code in IfController and WhileController from 5 to 15 to write more complex statements.

@codecov-commenter
Copy link

Codecov Report

Merging #665 (2052f5e) into master (25ab888) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
- Coverage     55.46%   55.35%   -0.12%     
- Complexity    10181    10193      +12     
============================================
  Files          1046     1046              
  Lines         64147    64437     +290     
  Branches       7265     7309      +44     
============================================
+ Hits          35580    35668      +88     
- Misses        26060    26263     +203     
+ Partials       2507     2506       -1     
Impacted Files Coverage Δ Complexity Δ
...g/apache/jmeter/control/gui/IfControllerPanel.java 68.00% <100.00%> (ø) 8.00 <0.00> (ø)
.../apache/jmeter/control/gui/WhileControllerGui.java 78.12% <100.00%> (ø) 7.00 <0.00> (ø)
...protocol/bolt/sampler/AbstractBoltTestElement.java 61.29% <0.00%> (-18.71%) 12.00% <0.00%> (+6.00%) ⬇️
...he/jmeter/protocol/http/gui/HTTPFileArgsPanel.java 33.64% <0.00%> (-14.54%) 9.00% <0.00%> (ø%)
...ter/protocol/http/proxy/SamplerCreatorFactory.java 27.90% <0.00%> (-13.96%) 4.00% <0.00%> (-1.00%)
...rg/apache/jmeter/util/keystore/JmeterKeyStore.java 24.35% <0.00%> (-2.70%) 7.00% <0.00%> (ø%)
.../org/apache/jmeter/config/gui/RowDetailDialog.java 9.84% <0.00%> (-2.42%) 1.00% <0.00%> (ø%)
...er/protocol/bolt/config/BoltConnectionElement.java 12.19% <0.00%> (-2.10%) 4.00% <0.00%> (ø%)
...ter/extractor/json/jmespath/JMESPathExtractor.java 79.46% <0.00%> (-1.85%) 34.00% <0.00%> (+1.00%) ⬇️
...a/org/apache/jmeter/config/gui/ArgumentsPanel.java 45.62% <0.00%> (-0.83%) 30.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ab888...2052f5e. Read the comment docs.

@dgetzlaf dgetzlaf changed the title Increase visible lines of code in IfControllerPanel and WhileControll… Increase visible lines of code in IfController and WhileController May 19, 2021
@asfgit asfgit closed this in 7842529 May 23, 2021
@FSchumacher
Copy link
Contributor

Thanks for the patch.
I have chosen a different path, but I hope, that you still like the result.

@dgetzlaf
Copy link
Contributor Author

@FSchumacher thank you very much for implementing a nice fix ! :)

@dgetzlaf dgetzlaf deleted the more-visible-lines-for-if-and-whilecontroller branch May 24, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants