Hack to make rendering of large text results faster#706
Closed
FSchumacher wants to merge 2 commits intoapache:masterfrom
Closed
Hack to make rendering of large text results faster#706FSchumacher wants to merge 2 commits intoapache:masterfrom
FSchumacher wants to merge 2 commits intoapache:masterfrom
Conversation
Currently the used JEditorPane is slow when using large texts, as it tries to find good places to break words. This hack disables word wrapping by using non-wrapping views for every element in the JEditorPane.
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
============================================
- Coverage 55.54% 55.23% -0.32%
- Complexity 10350 10377 +27
============================================
Files 1061 1061
Lines 65220 65706 +486
Branches 7433 7531 +98
============================================
+ Hits 36229 36291 +62
- Misses 26432 26815 +383
- Partials 2559 2600 +41
Continue to review full report at Codecov.
|
…results tree This setting is used to decide, whether the text view should switch to a simpler view model. That can help to get rid of UI unresponsiveness on large contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the used JEditorPane is slow when using large texts, as it
tries to find good places to break words.
This hack disables word wrapping by using non-wrapping views
for every element in the JEditorPane.
How Has This Been Tested?
Sampled a biggish http site and looked at the result in the view results tree. Especially switching between a small and a large text result, would take a few seconds and make the UI unresponsive.
Screenshots (if appropriate):
Types of changes
Checklist: