Skip to content

[65318] JSON Assertion: Use correct number format#723

Closed
andreaslind01 wants to merge 1 commit intoapache:masterfrom
andreaslind01:bug_65318
Closed

[65318] JSON Assertion: Use correct number format#723
andreaslind01 wants to merge 1 commit intoapache:masterfrom
andreaslind01:bug_65318

Conversation

@andreaslind01
Copy link
Contributor

@andreaslind01 andreaslind01 commented Aug 9, 2022

Description

See https://bz.apache.org/bugzilla/show_bug.cgi?id=65318

Motivation and Context

This PR fixes the issues with JSON Assertions mentioned here: https://bz.apache.org/bugzilla/show_bug.cgi?id=65318

How Has This Been Tested?

Tested with the example testplan provided in the issue.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.24%. Comparing base (b73f690) to head (c337824).
Report is 533 commits behind head on master.

Files with missing lines Patch % Lines
...rg/apache/jmeter/assertions/JSONPathAssertion.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #723   +/-   ##
=========================================
  Coverage     55.24%   55.24%           
- Complexity    10386    10387    +1     
=========================================
  Files          1062     1062           
  Lines         65777    65777           
  Branches       7536     7536           
=========================================
+ Hits          36337    36339    +2     
+ Misses        26839    26838    -1     
+ Partials       2601     2600    -1     
Files with missing lines Coverage Δ
...rg/apache/jmeter/assertions/JSONPathAssertion.java 78.57% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73f690...c337824. Read the comment docs.

@FSchumacher
Copy link
Contributor

This was created to address #5539, but the attached test case does not fail any more (tested on current branch). Is this PR still needed?

@andreaslind01
Copy link
Contributor Author

This was created to address #5539, but the attached test case does not fail any more (tested on current branch). Is this PR still needed?

For me the attached test case still fails - please see #5539 (comment)

asfgit pushed a commit that referenced this pull request Apr 29, 2023
@FSchumacher
Copy link
Contributor

PR has been merged.
Thanks for your PR and your insistence :)
Could you test the current trunk or next nightly?

@andreaslind01
Copy link
Contributor Author

Thanks for merging the PR @FSchumacher.
I've tested it with the current nightly and it works like a charm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants