Skip to content

Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf #15212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 2 commits into from
Apr 19, 2022
Merged

Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf #15212

lhotari merged 2 commits into from
Apr 19, 2022

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Apr 19, 2022 •
edited
Loading

Fixes #14015

Motivation

Since the current version is 4.1.74.Final, the upgrade will also contain 4.1.75.Final changes,

A notable change that comes with Netty Tcnative 2.0.51.Final is the change that boringssl native libraries are packaged in separate jar file. That change seems to have been made in netty/netty-tcnative#696 in Netty Tcnative 2.0.49.Final .

grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final: grpc/grpc-java#9004

Modifications

Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final
Upgrade grpc to 1.45.1
Upgrade protobuf to 3.19.2

@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Apr 19, 2022
@lhotari lhotari self-assigned this Apr 19, 2022
@lhotari lhotari added this to the 2.11.0 milestone Apr 19, 2022
@RobertIndie RobertIndie added the area/dependency Pull requests that update a dependency file label Apr 19, 2022
@hezhangjian
Copy link
Member

hezhangjian commented Apr 19, 2022

I don't know if we can easily update version, I meeted a grpc problem grpc/grpc-java#9004 when I try to upgrage netty version in bookkeeper apache/bookkeeper#3163
It requires a grpc update

@lhotari lhotari force-pushed the lh-netty-4.1.76.Final branch from 7053221 to de79918 Compare April 19, 2022 08:30
@lhotari
Copy link
Member Author

lhotari commented Apr 19, 2022

I don't know if we can easily update version, I meeted a grpc problem grpc/grpc-java#9004 when I try to upgrage netty version in bookkeeper apache/bookkeeper#3163 It requires a grpc update

Thanks for the heads up. I guess I'll need to do a similar upgrade for Pulsar dependencies.

btw. It would be good to get that resolved in Bookkeeper 4.15.0 release.

@lhotari lhotari changed the title Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf Apr 19, 2022
@lhotari lhotari force-pushed the lh-netty-4.1.76.Final branch from f92ab73 to d690028 Compare April 19, 2022 09:34
@lhotari
Upgrade grpc to 1.45.1 and protobuf to 3.19.2
c282f1f 
- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004
@lhotari lhotari force-pushed the lh-netty-4.1.76.Final branch from d690028 to c282f1f Compare April 19, 2022 10:35
@hezhangjian hezhangjian mentioned this pull request Apr 19, 2022
Closed
4 tasks
@lhotari lhotari merged commit 332a3c7 into apache:master Apr 19, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@lhotari
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
622b485 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004
@lhotari lhotari mentioned this pull request Apr 20, 2022
Merged
lhotari added a commit to datastax/pulsar that referenced this pull request Apr 20, 2022
@lhotari
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
4afb0a6 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
gaoran10 pushed a commit that referenced this pull request Apr 21, 2022
@lhotari @gaoran10
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (#15212
a547163 
)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes #14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
@gaoran10 gaoran10 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Apr 21, 2022
gaoran10 pushed a commit that referenced this pull request Apr 21, 2022
@lhotari @gaoran10
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (#15212
4fb5180 
)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes #14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
@gaoran10 gaoran10 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Apr 21, 2022
lhotari added a commit to datastax/pulsar that referenced this pull request Apr 22, 2022
@lhotari
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
65c2a59 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
lhotari added a commit to datastax/pulsar that referenced this pull request Apr 22, 2022
@lhotari
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
4079eb9 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
@lhotari lhotari mentioned this pull request Apr 22, 2022
Merged
@nicoloboschi
Copy link
Contributor

nicoloboschi commented Apr 28, 2022

@lhotari this pull is not present in branch-2.10

pulsar/pom.xml

Line 113 in 09819b2

<netty.version>4.1.74.Final</netty.version>

please cherry-pick it as well

codelipenghui pushed a commit that referenced this pull request Apr 28, 2022
@lhotari @codelipenghui
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (#15212
d39c655 
)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes #14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Apr 28, 2022
@lhotari @nicoloboschi
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
395ac6b 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
@gaozhangmin gaozhangmin mentioned this pull request May 17, 2022
Closed
Jason918 pushed a commit to Jason918/pulsar that referenced this pull request Aug 1, 2022
@lhotari @Jason918
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
b7229b9 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
@Jason918 Jason918 mentioned this pull request Aug 1, 2022
Closed
2 tasks
@Jason918
Copy link
Contributor

Jason918 commented Aug 1, 2022

Move release/2.7.5 label to #16896

Jason918 pushed a commit to Jason918/pulsar that referenced this pull request Aug 1, 2022
@lhotari @Jason918
Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf (apa…
78c6f94 
…che#15212)

* Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final

Fixes apache#14015
- release notes https://netty.io/news/2022/04/12/4-1-76-Final.html
  - contains fix for netty/netty#11695

* Upgrade grpc to 1.45.1 and protobuf to 3.19.2

- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final
  - grpc/grpc-java#9004

(cherry picked from commit 332a3c7)
@hpvd hpvd mentioned this pull request Nov 11, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@Jason918 Jason918 Awaiting requested review from Jason918

@eolivelli eolivelli Awaiting requested review from eolivelli

@hezhangjian hezhangjian Awaiting requested review from hezhangjian

@dave2wave dave2wave Awaiting requested review from dave2wave

Assignees

@lhotari lhotari

Labels

area/dependency Pull requests that update a dependency file cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.8.4 release/2.9.3 release/2.10.1

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

Excessive CPU use in idle mode

8 participants

@lhotari @hezhangjian @nicoloboschi @Jason918 @codelipenghui @gaoran10 @RobertIndie @Demogorgon314