Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Core] Optimize package logic #5223

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

VolodymyrDuke
Copy link
Contributor

Move jdbc driver jars into plugins

Purpose of this pull request

Check list

@VolodymyrDuke VolodymyrDuke changed the title [Improve][Core] Optimize package logic] [Improve][Core] Optimize package logic Aug 4, 2023
@EricJoy2048
Copy link
Member

@Hisoka-X PTAL

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 5, 2023

Hi, can you explain why want to change this?

@VolodymyrDuke
Copy link
Contributor Author

Hi, can you explain why want to change this?

When we pakcage manually, all jdbc driver jars will be put in lib/, every seatunnel job before start it will load all jars in lib, so if any jobs doesn't need these dependencies, it maybe casue jar conflict. This change only infect the package manually. e.g. : mvn clean package -Pci. But we have another concern about it because all ci steps do not be executed. This change whether infect the jdbc connectors we don't a clearly result.

@Hisoka-X
Copy link
Member

so if any jobs doesn't need these dependencies, it maybe casue jar conflict

Seem this PR doesn't fix this error. All driver also would be loaded when submit a job if put it in plugin/lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants